Ticket #70 (assigned defect)

Opened 2 years ago

Last modified 2 months ago

missing giftext or giffix is dangerous

Reported by: halley@play-bow.us Assigned to: decoder (accepted)
Priority: major Milestone:
Component: Image Analysis Version:
Keywords: Cc:

Description

I neglected to install libgif-utils on FC6, and so was missing giftext and giffix. FuzzyOCR's logs showed it trying to exec a string that was the concatenation of an empty $rcmd + the input filename, which resulted in

dbg: FuzzyOcr?: Exec : /tmp/.spamassassin5733JVhP4Ptmp/CIMG0980.gif

which seems like a very bad thing!

I believe the root cause of this is FuzzyOcr?.pm line 406. It looks like the code there is trying to guard the following code, i.e. "if any of these programs are missing, go to the next file". Unfortunately, the scope of the "next" is referring to is the foreach, not the main file loop, and so it remains possible to use undefined values in the subsequent code.

(This is FuzzyOcr?.pm from the svn trunk)

Attachments

Change History

21.01.2007 16:06:16 changed by decoder

  • status changed from new to assigned.

You are absolutely right, I will fix this asap

15.08.2007 02:25:48 changed by anonymous

13.08.2008 12:16:17 changed by anonymous

I'm closing it according to the last comment.
----------
eric air max


Add/Change #70 (missing giftext or giffix is dangerous)